[PATCH] D153576: [Headers] Fix up some conditionals

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 23 04:12:02 PDT 2023


pengfei added a comment.

In D153576#4442096 <https://reviews.llvm.org/D153576#4442096>, @craig.topper wrote:

> The mulx function being 32-bit mode only is also true in gcc. It probably won't generate a mulx instruction on x86-64. Maybe that's why it was 32-bit only? But it should still be functionally correct.

It's not functionally correct. Candidate fix D153620 <https://reviews.llvm.org/D153620>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153576/new/

https://reviews.llvm.org/D153576



More information about the cfe-commits mailing list