[PATCH] D153476: [dataflow] document & test determinism of formula structure
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 23 02:40:32 PDT 2023
gribozavr2 added inline comments.
================
Comment at: clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp:165-169
+ auto &BX = A.create<AtomicBoolValue>();
+ auto &BY = A.create<AtomicBoolValue>();
+ auto &BAnd = A.makeAnd(BX, BY);
+ auto &BOr = A.makeOr(BY, BX);
+ auto &BEqual = A.makeEquals(BOr, BAnd);
----------------
================
Comment at: clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp:169
+ auto &BOr = A.makeOr(BY, BX);
+ auto &BEqual = A.makeEquals(BOr, BAnd);
+ EXPECT_EQ(Expected, llvm::to_string(B.getFormula(BEqual)));
----------------
gribozavr2 wrote:
> Shouldn't these lines use "A.make...()"?
Sorry, I meant, shouldn't these lines use "B.make...()"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153476/new/
https://reviews.llvm.org/D153476
More information about the cfe-commits
mailing list