[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 23 01:31:56 PDT 2023


hokein added inline comments.


================
Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:160
     auto Results =
         analyze(AST.Roots, PP.MacroReferences, PP.Includes, &PI, SM, HS);
     if (!Insert)
----------------
kadircet wrote:
> we actually want to perform filtering inside `analyze`. it's not enough to filter only when printing, we should also filter before applying fixes :D. but we should also be applying filtering to absolute paths in all cases, for missing includes this is being applied to spelling instead.
oops, good catch. Added an actual --edit test. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153340/new/

https://reviews.llvm.org/D153340



More information about the cfe-commits mailing list