[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 22 16:01:36 PDT 2023


dblaikie added a comment.

Basing this on "defined" or "undefined" member functions isn't /perfectly/ correct (though might be correct enough for this flag - though I do prefer something about "canonicality" of types, but perhaps it's too inside-baseball for the average user - though these debug info flags are pretty esoteric at the best of times anyway) - we might emit member function declarations for call sites in DWARF, for instance (seems currently we don't emit call sites for member function calls, but I don't think it's a fundamental issue - just something no one's implemented yet/maybe a heuristic for what's worth describing call sites for) - also, while we don't do it currently, I've just been thinking about template info completeness and we don't currently reference DIEs for non-type-template parameters of pointer type, including function/member function pointers, and it'd be nice if we did point to the actual DIE describing the thing we're pointing to, in which case we'd need to emit some more function declarations there too.

Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152017/new/

https://reviews.llvm.org/D152017



More information about the cfe-commits mailing list