[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 22 14:39:52 PDT 2023


zahiraam created this revision.
zahiraam added reviewers: rjmccall, andrew.w.kaylor, aaron.ballman.
Herald added a subscriber: jdoerfert.
Herald added a project: All.
zahiraam requested review of this revision.
Herald added a project: clang.

When float_t and double_t types are used inside a scope with a '#pragma clang fp eval_method', it can lead to ABI breakage.
See https://godbolt.org/z/56zG4Wo91
This patch prevents this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153590

Files:
  clang/docs/LanguageExtensions.rst
  clang/include/clang/Basic/Attr.td
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Basic/TokenKinds.def
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaDeclAttr.cpp
  clang/lib/Sema/SemaExpr.cpp
  clang/test/Misc/pragma-attribute-supported-attributes-list.test
  clang/test/Sema/abi-check-1.cpp
  clang/test/Sema/abi-check-2.cpp
  clang/test/Sema/abi-check-3.cpp
  clang/test/Sema/attr-only-in-default-eval.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153590.533786.patch
Type: text/x-patch
Size: 15769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230622/accbe967/attachment-0001.bin>


More information about the cfe-commits mailing list