[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 22 12:34:02 PDT 2023


HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:3476-3477
+
+  // Regarding the 16: Note that multiple passes are added in
+  // addQualifierAlignmentFixerPasses().
+  SmallVector<AnalyzerPass, 16> Passes;
----------------
owenpan wrote:
> This comment is unnecessary and too verbose IMO. I suggest that it be deleted.
> This comment is unnecessary and too verbose IMO. I suggest that it be deleted.

I think one should note that there are more passes added than directly meets the eye here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153228/new/

https://reviews.llvm.org/D153228



More information about the cfe-commits mailing list