[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Tom Honermann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 22 11:14:03 PDT 2023


tahonermann accepted this revision.
tahonermann added a comment.
This revision is now accepted and ready to land.

The static analysis results look suspect since there does not appear to be a way for `Log2_32` to return a value larger than 31. Regardless, the change looks safe to me; `GV_Warp_Size` should always be greater than 0, so `Log2_32` should always return a non-negative number that is less than 32.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151606/new/

https://reviews.llvm.org/D151606



More information about the cfe-commits mailing list