[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 22 07:03:06 PDT 2023


tejohnson added inline comments.


================
Comment at: clang/test/CodeGen/verify-each.c:5
+// RUN: %clang_cc1 -O2 -o /dev/null -triple x86_64-unknown-linux-gnu -emit-llvm-bc %s -fdebug-pass-manager 2>&1 | FileCheck %s --check-prefix=NO
+// NO-NOT: Verifying
+
----------------
Huh, really surprised we are never normally running the verifier through clang! How did we hit the verification error you used this to narrow down in the first place?


================
Comment at: clang/test/CodeGen/verify-each.c:14
+
+// CHECK: Verifying
+
----------------
Might be slightly more robust to check for one specific opt pass having a verifier run both before and after it, rather than for a single run of the verifier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153468/new/

https://reviews.llvm.org/D153468



More information about the cfe-commits mailing list