[PATCH] D153418: Adding iconv support to CharSetConverter class

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added a comment.

In D153418#4438766 <https://reviews.llvm.org/D153418#4438766>, @efriedma wrote:

> This doesn't really address the concerns from https://discourse.llvm.org/t/rfc-adding-a-charset-converter-to-the-llvm-support-library/69795/17 about consistency.  It's bad if different hosts support a different set of charsets/charset names, and it's really bad if a given charset name has different meanings on different hosts.

I agree, in particular we know that the people most likely to use this feature are windows users, and iconv doesn't do anything for them.

> Can we use the existing conversion utilities in LLVM for UTF-16/UTF-32?

Not sure how useful this would be, UTF-16/UTF-32 facilities are used directly when they are needed, and utf-16 source input files are rare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153418/new/

https://reviews.llvm.org/D153418