[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

David Spickett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 22 01:25:46 PDT 2023


DavidSpickett added a comment.

Please tag the commit title with the subproject, `[clang]` in this case. If only to help your friendly neighborhood buildbot minder.

I'd maybe go with "Did you mean" instead of "try" but only because the first thing I think is well if I try it what will I get. Then again we're not going to fit an explanation of Arm triples into a warning message. I know elsewhere we already have "did you mean" but if "try" is already used too it's fine as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153430/new/

https://reviews.llvm.org/D153430



More information about the cfe-commits mailing list