[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 20:47:48 PDT 2023


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaModule.cpp:835
+
+  //  C++20 [module.interface]p3:
   if (auto *ND = dyn_cast<NamedDecl>(D)) {
----------------
Can you please add the quoted text for clarity. This is especially helpful if the text changes in the future and we are left trying to read the tea leaves to determine motivation. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152946/new/

https://reviews.llvm.org/D152946



More information about the cfe-commits mailing list