[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

Wed Jun 21 20:42:12 PDT 2023

sammccall added reviewers: gribozavr2, xazax.hun, mboehme.
sammccall added a comment.

Splitting out Formula from BoolValue is a pretty big change... I've tried to keep this patch a manageable size by really just using Formula for interacting with the SAT solver and some printing, but this means we're maintaining BoolValues and Formulas in parallel for now. Best to take a look at Formula.h, then look ahead to D153469 <https://reviews.llvm.org/D153469> to see how we can eliminate the BoolValue subclasses, stop using Values as flow conditions in DataflowAnalysisContext, etc.

Would be very happy to hear high-level feedback/concerns first.
(I do know there's a bunch of places where words in comments/variable names should likely change - I thought making all these up front may make this very noisy to review)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153366/new/

https://reviews.llvm.org/D153366