[PATCH] D153205: [clang-format] Add new block type ListInit

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 12:30:12 PDT 2023


HazardyKnusperkeks added a comment.

In D153205#4437966 <https://reviews.llvm.org/D153205#4437966>, @MyDeveloperDay wrote:

> My only concern is that this changes behaviour without someone making the conscious decision to make that change, now as much as I can't understand why someone would want to put the `}` onto the same line, it will only take on person to say "hey I liked it like that" to complain and call it a regression, or that we somehow change the defaults (which people always complain about even through we don't normally do that)
>
> In the past our solution to this problem is to have an option with a "Leave" setting to sort of say, leave it as it currently is. In this case it feels like a bug, looks like a bug and is probably a bug, but I'd be interested in @owenpan and @HazardyKnusperkeks's view

The github issue basically says all there's to say, if it those constructs should be formatted like function calls, then that's what should happen. Or we should adapt the documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153205/new/

https://reviews.llvm.org/D153205



More information about the cfe-commits mailing list