[PATCH] D146148: [clang] Add a namespace for interesting identifiers.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 11:43:40 PDT 2023


rjmccall added a comment.

Yes, this is very close, thank you.



================
Comment at: clang/include/clang/Basic/TokenKinds.def:805
+INTERESTING_IDENTIFIER(float_t)
+INTERESTING_IDENTIFIER(double_t)
+INTERESTING_IDENTIFIER(FILE)
----------------
I think it would be cleaner if you added these two as interesting identifiers in your follow-up patch.


================
Comment at: clang/lib/Sema/SemaLookup.cpp:950
+          return true;
+        }
         // In C++ and OpenCL (spec v1.2 s6.9.f), we don't have any predefined
----------------
The two changes in this file shouldn't be necessary, since interesting identifiers should be disjoint from builtins.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146148/new/

https://reviews.llvm.org/D146148



More information about the cfe-commits mailing list