[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

Christopher Di Bella via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 11:31:02 PDT 2023


cjdb added a comment.

I think this will be a good addition because it underscores the salient part of why the function isn't viable.

Would it be possible for patches like this to have both examples of before and after this patch in their commit message please? That'll help expose why patches like this are desirable. Happy to LGTM afterwards.



================
Comment at: clang/test/Misc/diag-func-call-ranges.cpp:13
+void arity_mismatch() {
+  (void)func(2, 4);
+}
----------------
Why are you casting to void?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153267/new/

https://reviews.llvm.org/D153267



More information about the cfe-commits mailing list