[PATCH] D153418: Adding iconv support to CharSetConverter class

[Michael Platings via Phabricator via cfe-commits]

michaelplatings added inline comments.


================
Comment at: clang/lib/Basic/CMakeLists.txt:62
+if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN)
+  set(system_libs ${system_libs} ${Iconv_LIBRARIES})
+endif()
----------------
This doesn't look like an idomatic way to link a library. Could you use [[ https://cmake.org/cmake/help/latest/command/target_link_libraries.html | target_link_libraries ]] instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153418/new/

https://reviews.llvm.org/D153418