[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

[Jens Massberg via Phabricator via cfe-commits]

massberg marked an inline comment as done.
massberg added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051
 
+TEST(Hover, RewrittenBinaryOperatorSpaceshipMassberg) {
+  Annotations T(R"cpp(
----------------
sammccall wrote:
> massberg wrote:
> > massberg wrote:
> > > sammccall wrote:
> > > > sammccall wrote:
> > > > > no need to sign your work :-)
> > > > can you add this to HoverTest__All instead? That way we test all details of the hover card
> > > Upps, sorry.
> > > can you add this to HoverTest__All instead? That way we test all details of the hover card
> > 
> > The (Hover, All) test tests with `std=c++17` while this test tests c++20 features.
> > We could add an additional field with the version to the struct in the (Hover, All) test.
> > Or add a (Hover, All_Cpp20) test for testing C++20 (what is probably not worth at the moment with just one test requiring C++20).
> Does anything break if you switch everything to C++20?
> The intention of "std=c++17" there was certainly "not 14", rather than "not 20" :-)
Test test passed with C++20. I have switch it to C++20 and moved the new test as a new case in this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153331/new/

https://reviews.llvm.org/D153331