[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

Abel Bernabeu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 02:38:31 PDT 2023


abel-bernabeu updated this revision to Diff 533191.
abel-bernabeu added a comment.

Addressed some review comments:

- Doxygen-style comments are not common, so using triple-slash instead.
- Using a regular C array on a place where the usage of SmallVector is not justified.
- Proper capitalization of a variable
- Usage of "&&" rather than "and", to blend better with the existing code style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008

Files:
  llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  llvm/test/MC/RISCV/comments-zdinx.ll
  llvm/test/MC/RISCV/comments.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153008.533191.patch
Type: text/x-patch
Size: 12221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230621/9c44fbb2/attachment.bin>


More information about the cfe-commits mailing list