[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1586
 
+/**
+\brief Peeks next after next token
----------------
I don't think this style of comment is common in llvm.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1598
+  do {
+    SmallVector<AsmToken> Buf(10);
+    ReadCount = getLexer().peekTokens(Buf);
----------------
Can this be a regular array instead of a SmallVector?


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1601
+    for (size_t index = 0; index < ReadCount; ++index) {
+      AsmToken token = Buf[index];
+      if (token.getKind() != AsmToken::Comment) {
----------------
Capitalize variable names


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008