[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 20 05:13:49 PDT 2023


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!



================
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:219
+    // as they don't contribute to the main-file #include.
+    if (isa<ParmVarDecl>(VD))
+      return true;
----------------
s/isa/llvm::isa/


================
Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:101
+  // No reference reported for the Parameter.
+  using A = int(int time);
   )cpp");
----------------
no need for this one, as we already have a param in `bar`. can you just move the comment near that one instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153330/new/

https://reviews.llvm.org/D153330



More information about the cfe-commits mailing list