[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

Mon Jun 19 19:40:23 PDT 2023

owenpan added a comment.

In D153208#4433511 <https://reviews.llvm.org/D153208#4433511>, @HazardyKnusperkeks wrote:

> In D153208#4431697 <https://reviews.llvm.org/D153208#4431697>, @owenpan wrote:
>
>> In D153208#4431239 <https://reviews.llvm.org/D153208#4431239>, @HazardyKnusperkeks wrote:
>>
>>> We also could add a clang-format style, the you wouldn't have to to touch all .clang-format files. ;)
>>
>> Something like `BasedOnStyle: clang-format`? I like it but feel that it should be an undocumented feature. What do you all think?
>
> I don't know if I want this or if it just a joke. But if we do it, I would document it, something like. "Basically LLVM Style, which uses some of the newer options, to enforce some of the LLVM style guide rules."

That would seem odd with `LLVM`, `Google`, and other current `BasedOnStyle` values unless we make it hidden for "internal" use. I'll just land this patch as is and not worry about it now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153208/new/

https://reviews.llvm.org/D153208