[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 13:00:50 PDT 2023


HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.

Please wait for at least @MyDeveloperDay to say something, as he is the original author of the work.



================
Comment at: clang/lib/Format/Format.cpp:3475
       AnalyzerPass;
   SmallVector<AnalyzerPass, 8> Passes;
 
----------------
Sedeniono wrote:
> HazardyKnusperkeks wrote:
> > Just increase here, and add a comment that there are multiple passes added in `addQualifierAlignmentFixerPasses`.
> > 
> > I think the idea was and should be that we always store the pointers on the stack.
> Ok, done.
You don't need to comment done. But please check the "Done" on my comment. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153228/new/

https://reviews.llvm.org/D153228



More information about the cfe-commits mailing list