[PATCH] D153251: [clangd] Index the type of a non-type template parameter

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 19 11:36:13 PDT 2023


nridge planned changes to this revision.
nridge added inline comments.


================
Comment at: clang/lib/Index/IndexDecl.cpp:708
       } else if (const auto *NTTP = dyn_cast<NonTypeTemplateParmDecl>(TP)) {
+        IndexCtx.indexTypeSourceInfo(NTTP->getTypeSourceInfo(), Parent);
         if (NTTP->hasDefaultArgument())
----------------
hokein wrote:
> since this is a change in clang libindex, I think it would be better to have the unittest in (clang/unittests/Index/IndexTests.cpp).
Will do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153251/new/

https://reviews.llvm.org/D153251



More information about the cfe-commits mailing list