[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110
   FeatureBitset Features;
+  char Mangling;
+  bool OnlyForCPUDispatchSpecific;
----------------
Do we have a documented list of the mangling values anywhere? The values below look too much like magic numbers tbh.


================
Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:90
 ; RUN: llc < %s -o /dev/null -mtriple=x86_64-unknown-unknown -mcpu=graniterapids 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
+; RUN: llc < %s -o /dev/null -mtriple=x86_64-unknown-unknown -mcpu=atom_sse4_2_movbe 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
 
----------------
put this with the goldmonth checks?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151696/new/

https://reviews.llvm.org/D151696