[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

Sergei Barannikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 18 21:05:22 PDT 2023


barannikov88 added a comment.

- I'd prefer Lex() over equivalent getParser().Lex() because it is shorter.
- Ideally, every change should be tested.
- The tests should be minimal. That is, they should be assembly files passed to llvm-mc rather than ll files passed to llc.

I'm not very familiar with RISC-V, so I'll leave further review to code owners.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008



More information about the cfe-commits mailing list