[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd
Chuanqi Xu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 18 19:21:44 PDT 2023
ChuanqiXu added inline comments.
================
Comment at: clang-tools-extra/clangd/ModulesManager.cpp:413-414
+ else
+ WaitingCallables[Filename.str()].push_back(
+ {std::move(ReadyCallback), std::move(ReadyCallback)});
+}
----------------
Destroyerrrocket wrote:
> This is a bug; The second move is invalid. You could make a copy
Done. Thanks for looking this. I changed it with a new signature for the callbacks with a bool argument.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153114/new/
https://reviews.llvm.org/D153114
More information about the cfe-commits
mailing list