[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added a comment.

I'm shocked, astonished and in awe how small this patch is. Great work and explanation!



================
Comment at: clang/lib/Format/Format.cpp:3475
       AnalyzerPass;
   SmallVector<AnalyzerPass, 8> Passes;
 
----------------
Just increase here, and add a comment that there are multiple passes added in `addQualifierAlignmentFixerPasses`.

I think the idea was and should be that we always store the pointers on the stack.


================
Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:36
+
+  Passes.reserve(Passes.size() + LeftOrder.size() + RightOrder.size());
 
----------------
I think we can drop this, see my other comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153228/new/

https://reviews.llvm.org/D153228