[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

Pol M via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 18 05:15:06 PDT 2023


Destroyerrrocket requested changes to this revision.
Destroyerrrocket added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tools-extra/clangd/ModulesManager.cpp:413-414
+  else
+    WaitingCallables[Filename.str()].push_back(
+        {std::move(ReadyCallback), std::move(ReadyCallback)});
+}
----------------
This is a bug; The second move is invalid. You could make a copy


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153114/new/

https://reviews.llvm.org/D153114



More information about the cfe-commits mailing list