[PATCH] D153218: [clang-tidy] Fix `llvmlibc-inline-function-decl` false positives for templated function definitions

André Schackier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 18 02:13:56 PDT 2023


AMS21 added a comment.

Regarding the problems with attributes like nodiscard. I'm honestly not quite sure, but from the way the check is implemented and the warning is worded, it sounds to me like the attributes should come after LIBC_INLINE. Although looking at the Styleguide for libc, I didn't find anything the placement of the macro there.

I thinks its best for now to leave the behavior as it was.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153218/new/

https://reviews.llvm.org/D153218



More information about the cfe-commits mailing list