[PATCH] D152975: [clang-format] Allow break after return keyword

Gedare Bloom via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 17 11:23:16 PDT 2023


gedare added a comment.

In D152975#4425932 <https://reviews.llvm.org/D152975#4425932>, @HazardyKnusperkeks wrote:

> I'd like more tests (and examples how it is before the change), some operations (+, *, etc.), your stated string literal with and without many spaces, call chains.

Ok. Since it applies by default, all the existing unittests use it. I will see about fabricating some more interesting tests for it.

> I have nothing against the introduction, I'm just not sure about the default value and the position of the check in `splitPenalty`.

Yes the default was chosen arbitrarily.  Adding more tests to exercise return value lengths should help tune defaults.

> And please add a remark in the changelog.

Is there a separate changelog file?  I don't understand this request.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152975/new/

https://reviews.llvm.org/D152975



More information about the cfe-commits mailing list