[PATCH] D153123: Fix diag for read-only target features
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 16 11:15:19 PDT 2023
jdoerfert added inline comments.
================
Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8
+// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s
+// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is read only
----------------
yaxunl wrote:
> arsenm wrote:
> > Can you use -verify and expected-no-diagnostics? CHECK-NOT is really fragile
> -verify only works with clang -cc1, whereas we want to make sure there is no warning for the whole compilation invoked by clang driver
let's then check-not for any warning?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153123/new/
https://reviews.llvm.org/D153123
More information about the cfe-commits
mailing list