[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

[Abel Bernabeu via Phabricator via cfe-commits]

abel-bernabeu marked an inline comment as done.
abel-bernabeu added a comment.

In D153008#4428568 <https://reviews.llvm.org/D153008#4428568>, @MaskRay wrote:

> This new update still applies many unneeded `getParser().Lex();` and adds a test at a wrong layer <https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer> (clang/test/CodeGen):

Your comment in here suggests a full review of the parser to make the code consistent with the principle that a token should be eaten in the same function that checks for a specific pattern.

https://discourse.llvm.org/t/interleaving-several-c-style-comments-in-the-same-inline-assembly-line/71353/10

I like the suggestion, just a couple of questions:

- is it something that you would like to try yourself?
- do you want me to create a refactoring ticket for myself? Not sure when will I be highly available for a major refactor, but I can try to assign time at work for the task.

Let me know your preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008