[PATCH] D153152: Adds tweak to add declarations for pure virtuals

Robert Schneider via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 16 09:25:12 PDT 2023


robot added a comment.

This change is not done, I need some advice:

- I don't understand why there are two levels of data structures in an entry of the final overriders map, hence I can't properly name the variables nor do I fully understand what I'm doing there.
- It's not clear if the tweak should be available if there are no pure virtual functions.
- It's not clear if we need to handle the case that there are multiple final overriders, or what we should do in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153152/new/

https://reviews.llvm.org/D153152



More information about the cfe-commits mailing list