[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 19:25:03 PDT 2023


craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:2269
+
+    IntrinsicTypes = {ResultType, Ops[Offset]->getType(), Ops[Offset + 1]->getType(),
+                      Ops.back()->getType()};
----------------
craig.topper wrote:
> I think we if we used `LLVMTruncatedType<0>` in IntrinsicsRISCV.td we wouldn't need to pass to `Ops[Offset]->getType()` here. Which I think makes this code identical to the sadd ManualCodegen?
Oops I mean ExtendedType


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152879/new/

https://reviews.llvm.org/D152879



More information about the cfe-commits mailing list