[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 17:04:33 PDT 2023


efriedma added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1470
+                                ->getLambdaStaticInvoker()) &&
+             !Fn->getName().contains("__impl")) {
+    // If emitting a lambda with static invoker on X86 Windows, change
----------------
I'm not sure `__impl` is unique enough that user code will never use it.  (I mean, it's reserved, but we don't actually forbid using it.)

Can we use the isDelegateCall() bit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137872/new/

https://reviews.llvm.org/D137872



More information about the cfe-commits mailing list