[PATCH] D153059: [-Wunsafe-buffer-usage][WIP] Group parameter fix-its
Rashmi Mudduluru via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 15 14:54:40 PDT 2023
t-rasmud added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2264
+ // variable `x` implicates fixing `y`:
DepMapTy PtrAssignmentGraph{};
+
----------------
ziqingluo-90 wrote:
> ziqingluo-90 wrote:
> > How about changing the variable name to `PtrImplicationGraph`? For two variables `V` and `W`, if `W` is in `PtrImplicationGraph[V]`, it means fixing `V` implicates fixing `W`, right?
> @t-rasmud what do you think?
Sounds good! `PtrImplicationGraph ` conveys the same meaning as `PtrAssignmentGraph ` and is more generic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153059/new/
https://reviews.llvm.org/D153059
More information about the cfe-commits
mailing list