[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Looks great!



================
Comment at: clang/test/Driver/arm-execute-only.c:1
-// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \
+// RUN: %clang -c -### --target=thumbv6m-eabi -mexecute-only %s 2>&1 | \
+// RUN:   FileCheck -allow-empty --check-prefix CHECK-EXECUTE-ONLY %s
----------------
stuij wrote:
> MaskRay wrote:
> > If you don't check -cc1 options with FileCheck, you can also replace `-###` with `-fdriver-only -Werror` and drop two `-NOT:` patterns below. You can play with some examples to see its effect:)
> > 
> > If the `clang -c -fdriver-only -Werror` command gives no output, you can use `... 2>&1 | count 0`
> Very useful info. Thanks for the tips!
LGTM once the simplification is done (e.g. `clang -c -fdriver-only -Werror`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149444/new/

https://reviews.llvm.org/D149444