[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

I am not opposed to this solution, but I do anticipate some performance problems in the future. I wonder if copy-on-write, or some persistent data structures where copying is cheap would be a better strategy long term. But getting it right first and fast after sounds like a good strategy :)



================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:754-755
+
+  auto It = MemberLocToStruct.find(&Loc);
+  if (It != MemberLocToStruct.end()) {
+    // `Loc` is the location of a struct member so we need to also clear the
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153006/new/

https://reviews.llvm.org/D153006