[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

[Freddy, Ye via Phabricator via cfe-commits]

FreddyYe added inline comments.


================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:314
+ // Empty processor. Include X87 and CMPXCHG8 for backwards compatibility.
+  { {""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B, '\0', false },
+  { {"generic"}, CK_None, ~0U, FeaturesPentiumMMX & ~FeaturesPentiumMMX, 'A', true },
----------------
RKSimon wrote:
> Would it be better to move all of this into X86TargetParser.def ?
Feels so. My next step plan it to furtherly combine the feature list table in X86.td together.


================
Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:315
+  { {""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B, '\0', false },
+  { {"generic"}, CK_None, ~0U, FeaturesPentiumMMX & ~FeaturesPentiumMMX, 'A', true },
   // i386-generation processors.
----------------
RKSimon wrote:
> FeaturesPentiumMMX & ~FeaturesPentiumMMX ?
I think I was to initialize a null feature list but failed... Will refine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151696/new/

https://reviews.llvm.org/D151696