[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

thanks.



================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726
+TEST(Hover, FunctionParameterDefaulValueNotEvaluated) {
+  Annotations T("void foo(int p^aram = 5);");
+  TestTU TU = TestTU::withCode(T.code());
----------------
I believe this case should trigger a crash, but I don't see the crash with a trunk-built clangd, do we miss something here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153015/new/

https://reviews.llvm.org/D153015