[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

Viktoriia Bakalova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 06:03:14 PDT 2023


VitaNuo accepted this revision.
VitaNuo added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:49
   SourceLocation SymRefLocation;
+  include_cleaner::Symbol Sym;
   include_cleaner::Header Missing;
----------------
Consider making the whole `include_cleaner::SymbolReference` a field instead, since you're already using two out of its three fields here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153013/new/

https://reviews.llvm.org/D153013



More information about the cfe-commits mailing list