[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added a comment.

This looks not so good. In this way, we can't disambiguate other template types. At least we added the kind and a TODO here.

BTW, the attached test case is in fact in correct. See https://eel.is/c++draft/basic.def.odr#14.3, such mergeable declarations shouldn't be attached to named modules. (And this is also a defect that now we don't diagnose it correctly).

Even if you put them into the global module fragment, I think we should try to look other places like `isSameEntity` to solve this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153003/new/

https://reviews.llvm.org/D153003