[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

ChenZheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 14 19:55:40 PDT 2023


shchenz added a comment.

@qiongsiwu1 Hi, thanks for the patch. Almost good to me, except one small nit.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:700
+    CmdArgs.push_back(Args.MakeArgString(
+        Twine(PluginOptPrefix) + "-no-integrated-as=" + NoIntegratedAs));
+  else if (!UseIntegratedAs) {
----------------
Seems other options leverage the default value in the back end, for example the default value for `DisableIntegratedAS` in backend is false, so when the front end requires integrated-as, maybe we can save the option here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152924/new/

https://reviews.llvm.org/D152924



More information about the cfe-commits mailing list