[PATCH] D152856: [Driver] Allow warning for unclaimed TargetSpecific options

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: llvm/include/llvm/Option/Arg.h:53
+  /// This is used for generating an "argument unused" warning (without
+  /// clang::driver::options::TargetSpecific) or "unsupported option" error
+  /// (with TargetSpecific).
----------------
MaskRay wrote:
> mstorsjo wrote:
> > Technically, as this is a llvm level API, talking about clang specific behaviours here is a bit at the wrong level.
> Yes. LLVMOption was originally part of Clang and was moved to llvm/.
> 
> The "argument unused" string is also quite Clang-specific. There are other stuff talking about Clang behaviors, e.g.  suggestValueCompletions, `Alias` (`-finput-charset=utf-8`). I wish that this is not too bad.
Ok, fair enough - consider this remark withdrawn then. Even if mislayered, detailed comments explaining the reason for the field is better than no explanations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152856/new/

https://reviews.llvm.org/D152856