[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Wed Jun 14 09:29:27 PDT 2023

Dinistro added a comment.

In D148697#4421420 <https://reviews.llvm.org/D148697#4421420>, @PiotrZSL wrote:

> In D148697#4421339 <https://reviews.llvm.org/D148697#4421339>, @Dinistro wrote:
>
>> In D148697#4421268 <https://reviews.llvm.org/D148697#4421268>, @PiotrZSL wrote:
>>
>>> In D148697#4420359 <https://reviews.llvm.org/D148697#4420359>, @Dinistro wrote:
>>>
>>>> I'm getting a linking error by some of the files changed in this revision.
>>>
>>> You shouldn't because this library got dependency on clangTidyPerformanceModule.
>>> Is this a blocker for you, or you can live with this for 1 day ? Until I verify this.
>>
>> I don't necessarily need to build clang-tidy, so it's fine for now.
>
> I did a clean build with shared libraries enabled, everything is working.
> I do not get those issues. Try a clean-build. I will try to check build with clang-16.

I tried with a clean build, and I get the exact same issues. Might be caused by the lld and clang-16 combination, not sure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148697/new/

https://reviews.llvm.org/D148697