[PATCH] D152747: [include-cleaner] Traverse implicit template instantations if the templates are inside the main file.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 14 02:42:41 PDT 2023
ilya-biryukov added a comment.
Though I'm not a reviewer, I was looking through the emails and found this change interesting. This is not intended to block the review in any way, just trying to get a picture of the direction include-cleaner is taking.
Is this a digression from the initial idea of include-what-you-spell?
I thought that the whole point was in trying to make the analysis more "local" and avoid relying on implicit instantiations.
What is our strategy on balancing the number of false-positive removals we produce with the number of false-negatives where we don't remove something that's actually unused?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152747/new/
https://reviews.llvm.org/D152747
More information about the cfe-commits
mailing list