[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 14 00:40:05 PDT 2023


MyDeveloperDay added a comment.

So whilst this solves the unit tests (and the golden.h issue) that were added it DOESN'T solve the overlapping replacements that was the original bug.

  struct foo {
  	void test() {
  #if 1
  #else
  #endif
  	}
  #if 1
  private:
  
  
  #endif
  };

This issue is caused by the `private:\n\n\n` and doesn't happen when there its only `private:\n\n` @owenpan , any thoughts, I'm abit stuck?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152804/new/

https://reviews.llvm.org/D152804



More information about the cfe-commits mailing list