[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 16:37:51 PDT 2023


sbc100 added a comment.

In D150803#4419370 <https://reviews.llvm.org/D150803#4419370>, @sunfish wrote:

> Would it make sense to call this "jspi" in practice, rather than "async"? Even though this isn't clang's decision per se anymore, it seems like the reasoning earlier in this review would still apply.

Did you mean to comment on the old PR?  This new PR doesn't propose either "jspi" or "async", but adds that ability to define custom attributes.. since that was deemed more flexible and forward thinking.   The decision as to which name emscripten will use for what can then be part of  different discussion/PR we hope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803



More information about the cfe-commits mailing list