[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

Noah Goldstein via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 14:03:01 PDT 2023


goldstein.w.n added a comment.

In D152226#4418978 <https://reviews.llvm.org/D152226#4418978>, @goldstein.w.n wrote:

> In D152226#4418498 <https://reviews.llvm.org/D152226#4418498>, @jdoerfert wrote:
>
>> FWIW, I wish the time that went into this would have been to improve and enable the (lightweight) Attributor pass.
>> Anyway, I'm still doing that, and the latest numbers didn't look that bad. I will start to upstream stuff that I found.
>> At this point it might be good to understand if the (lightweight) Attributor would solve your problems or what would be left.
>
> With the way the `InferCallsiteAttrs` is written, it should be equally usable in attributor as it is in FunctionAttrs. Guess my
> feeling was want to get this in s.t its actually usable. Once LW attributor becomes usable should be easy to apply `InferCallsiteAttrs`
> there.

Guess I'm assuming this will be usable in the Attributor. That is the goal. If its not the case am happy to refactor so that it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152226/new/

https://reviews.llvm.org/D152226



More information about the cfe-commits mailing list