[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

Tue Jun 13 13:47:48 PDT 2023

dschuff added a comment.

backend code looks pretty good. I'll defer to the clang experts for the clang part.

================
Comment at: lld/test/wasm/custom-undefine.s:17
+        .type   bar, at function
+bar:
+        .functype       bar () -> ()
----------------
I don't fully understand how this test is different from custom-attr.s. Bar is still defined, so the only thing I can see that's different is that it's not called. Is it relying on the linker GCing bar so that it's not defined? is the result different when bar is really undefined?

================
Comment at: lld/test/wasm/merge-custom-attr-section.ll:1
+; RUN: split-file %s %t
+; RUN: llc -filetype=obj %t/a.ll -o %t1.o
----------------
wow I didn't know this utility existed 🤯

================
Comment at: lld/test/wasm/merge-custom-attr-section.ll:7
+
+; Ensure two custo funct_attr sections are concatenated together.
+
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803